Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: net/quic/congestion_control/pacing_sender_test.cc

Issue 2064543002: Add a new rate based sending connection option which uses the pacing rate to keep the bytes_in_flig… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@124273380
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/congestion_control/pacing_sender_test.cc
diff --git a/net/quic/congestion_control/pacing_sender_test.cc b/net/quic/congestion_control/pacing_sender_test.cc
index e1f7b2e88d0b8d4d31339d3569c32f44272e8d8b..fbcbaa1984392a9f69e1f6992c09013c070d977b 100644
--- a/net/quic/congestion_control/pacing_sender_test.cc
+++ b/net/quic/congestion_control/pacing_sender_test.cc
@@ -43,7 +43,7 @@ class PacingSenderTest : public ::testing::Test {
mock_sender_ = new StrictMock<MockSendAlgorithm>();
pacing_sender_.reset(new PacingSender(
mock_sender_, QuicTime::Delta::FromMilliseconds(1), burst_size));
- EXPECT_CALL(*mock_sender_, PacingRate()).WillRepeatedly(Return(bandwidth));
+ EXPECT_CALL(*mock_sender_, PacingRate(_)).WillRepeatedly(Return(bandwidth));
}
void CheckPacketIsSentImmediately(HasRetransmittableData retransmittable_data,
@@ -363,7 +363,7 @@ TEST_F(PacingSenderTest, VerifyInnerSenderCalled) {
EXPECT_CALL(*mock_sender_, OnPacketSent(kTime, kBytes, 123u, kBytes,
HAS_RETRANSMITTABLE_DATA));
- EXPECT_CALL(*mock_sender_, PacingRate()).WillOnce(Return(kBandwidth));
+ EXPECT_CALL(*mock_sender_, PacingRate(_)).WillOnce(Return(kBandwidth));
pacing_sender_->OnPacketSent(kTime, kBytes, 123u, kBytes,
HAS_RETRANSMITTABLE_DATA);
@@ -377,8 +377,8 @@ TEST_F(PacingSenderTest, VerifyInnerSenderCalled) {
.WillOnce(Return(kTimeDelta));
pacing_sender_->TimeUntilSend(kTime, kBytes);
- EXPECT_CALL(*mock_sender_, PacingRate()).WillOnce(Return(kBandwidth));
- EXPECT_EQ(kBandwidth, pacing_sender_->PacingRate());
+ EXPECT_CALL(*mock_sender_, PacingRate(_)).WillOnce(Return(kBandwidth));
+ EXPECT_EQ(kBandwidth, pacing_sender_->PacingRate(0));
EXPECT_CALL(*mock_sender_, BandwidthEstimate()).WillOnce(Return(kBandwidth));
EXPECT_EQ(kBandwidth, pacing_sender_->BandwidthEstimate());
« no previous file with comments | « net/quic/congestion_control/pacing_sender.cc ('k') | net/quic/congestion_control/send_algorithm_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698