net/disk_cache/blockfile/block_files.cc - Issue 206453003: Move Preload() code to MappedFile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/block_files.cc

Issue 206453003: Move Preload() code to MappedFile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: New attempt Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/block_files.cc

diff --git a/net/disk_cache/blockfile/block_files.cc b/net/disk_cache/blockfile/block_files.cc

index 3f4bbf5274c3212d812f5b87ef7502ef65649bb7..ac6114ee746b7b3595ef23a4027d5655fe9c7888 100644

--- a/net/disk_cache/blockfile/block_files.cc

+++ b/net/disk_cache/blockfile/block_files.cc

@@ -508,9 +508,8 @@ bool BlockFiles::OpenBlockFile(int index) {

}

if (index == 0) {

- // Load the links file into memory with a single read.

- scoped_ptr<char[]> buf(new char[file_len]);

- if (!file->Read(buf.get(), file_len, 0))

+ // Load the links file into memory.

+ if (!file->Preload())

return false;

}