Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: build/common.gypi

Issue 206453002: Introduce USE_OPENSSL_CERTS for certificate handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final fixes and nits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crypto/crypto.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 4cc5eb2f2c742bb8f935f7fb91ec2494e9134429..cc4093dc5c14775bd8e3caf2f9cdd6a983424419 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -57,9 +57,15 @@
# Whether we are using Views Toolkit
'toolkit_views%': 0,
- # Use OpenSSL instead of NSS. Under development: see http://crbug.com/62803
+ # Use OpenSSL instead of NSS as the underlying SSL and crypto
+ # implementation. Certificate verification will in most cases be
+ # handled by the OS. If OpenSSL's struct X509 is used to represent
+ # certificates, use_openssl_certs must be set.
'use_openssl%': 0,
+ # Typedef X509Certificate::OSCertHandle to OpenSSL's struct X509*.
+ 'use_openssl_certs%': 0,
+
# Disable viewport meta tag by default.
'enable_viewport%': 0,
@@ -135,6 +141,7 @@
'use_ozone%': '<(use_ozone)',
'embedded%': '<(embedded)',
'use_openssl%': '<(use_openssl)',
+ 'use_openssl_certs%': '<(use_openssl_certs)',
'use_system_fontconfig%': '<(use_system_fontconfig)',
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
@@ -256,6 +263,7 @@
'use_clipboard_aurax11%': '<(use_clipboard_aurax11)',
'embedded%': '<(embedded)',
'use_openssl%': '<(use_openssl)',
+ 'use_openssl_certs%': '<(use_openssl_certs)',
'use_system_fontconfig%': '<(use_system_fontconfig)',
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
@@ -561,6 +569,14 @@
'use_nss%': 0,
}],
+ # When OpenSSL is used for SSL and crypto on Unix-like systems, use
+ # OpenSSL's certificate definition.
+ ['(OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris") and use_openssl==1', {
+ 'use_openssl_certs%': 1,
+ }, {
+ 'use_openssl_certs%': 0,
+ }],
+
# libudev usage. This currently only affects the content layer.
['OS=="linux" and embedded==0', {
'use_udev%': 1,
@@ -923,6 +939,7 @@
'use_cras%': '<(use_cras)',
'use_mojo%': '<(use_mojo)',
'use_openssl%': '<(use_openssl)',
+ 'use_openssl_certs%': '<(use_openssl_certs)',
'use_nss%': '<(use_nss)',
'use_udev%': '<(use_udev)',
'os_bsd%': '<(os_bsd)',
@@ -1545,6 +1562,7 @@
# Always uses openssl.
'use_openssl%': 1,
+ 'use_openssl_certs%': 1,
'proprietary_codecs%': '<(proprietary_codecs)',
'safe_browsing%': 2,
@@ -2571,9 +2589,18 @@
}],
], # conditions for 'target_defaults'
'target_conditions': [
- ['<(use_openssl)==1 or >(nacl_untrusted_build)==1', {
+ ['<(use_openssl)==1', {
'defines': ['USE_OPENSSL=1'],
}],
+ ['<(use_openssl_certs)==1', {
+ 'defines': ['USE_OPENSSL_CERTS=1'],
+ }],
+ ['>(nacl_untrusted_build)==1', {
+ 'defines': [
+ 'USE_OPENSSL=1',
+ 'USE_OPENSSL_CERTS=1',
+ ],
+ }],
['<(use_nss)==1 and >(nacl_untrusted_build)==0', {
'defines': ['USE_NSS=1'],
}],
« no previous file with comments | « no previous file | crypto/crypto.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698