Introduce USE_OPENSSL_CERTS for certificate handling.

net/socket/ssl_client_socket_openssl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_client_socket.h"
 
 #include <errno.h>
 #include <string.h>
 
 #include <openssl/bio.h>
@@ skipping 43 matching lines @@
 // BIO_free is a macro, it can't be used as a template parameter.
 void BIO_free_func(BIO* bio) {
     BIO_free(bio);
 }
 
 typedef crypto::ScopedOpenSSL<BIO, BIO_free_func> ScopedBIO;
 typedef crypto::ScopedOpenSSL<RSA, RSA_free> ScopedRSA;
 typedef crypto::ScopedOpenSSL<BIGNUM, BN_free> ScopedBIGNUM;
 
 const SSLConfig kDefaultSSLConfig;
-
+#if defined(USE_OPENSSL_CERTS) || defined(OS_ANDROID)

[wtc, 2014/03/20 21:14:56]

Why do you need to comment out this code?

[haavardm, 2014/03/21 13:08:21]

Thanks, I think I got this wrong. It should probably !defined(USE_OPENSSL_CERTS)
here instead. 

On OS X/Windows the OpenSSL versions of private keys and cert store would not be
implemented. The reason I kept the compilation of this file in the net.gyp is
that we might want to add non cert-store tests later. The name of the file is
ssl_client_socket_openssl_unittest.cc after all.

 // A ServerBoundCertStore that always returns an error when asked for a
 // certificate.
 class FailingServerBoundCertStore : public ServerBoundCertStore {
   virtual int GetServerBoundCert(const std::string& server_identifier,
                                  base::Time* expiration_time,
                                  std::string* private_key_result,
                                  std::string* cert_result,
                                  const GetCertCallback& callback) OVERRIDE {
     return ERR_UNEXPECTED;
   }
@@ skipping 278 matching lines @@
   EnabledFailingChannelID();
   SSLConfig ssl_config = kDefaultSSLConfig;
   ssl_config.channel_id_enabled = true;
 
   int rv;
   ASSERT_TRUE(CreateAndConnectSSLClientSocket(ssl_config, &rv));
 
   EXPECT_EQ(ERR_UNEXPECTED, rv);
   EXPECT_FALSE(sock_->IsConnected());
 }
-
+#endif  // defined(USE_OPENSSL_CERTS) || defined(OS_ANDROID)
 }  // namespace
 }  // namespace net