GN: Add Windows support to bootstrap.py

GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat" x86
> tools/gn/bootstrap/bootstrap.py

BUG=

Committed: https://crrev.com/3a32f0297bbd2c5673cf02923244ecfeda927b32
Cr-Commit-Position: refs/heads/master@{#403499}

[timn, 2016-06-12 19:56:18]

tim@rnc-ag.de changed reviewers:
+ brettw@chromium.org, dpranke@chromium.org

[brettw, 2016-06-13 00:25:39]

I don't understand what problem this is trying to solve. Can you elaborate in
the CL description?

[timn, 2016-06-13 07:50:11]

Description was changed from

==========
GN: Add support for Visual Studio to bootstrap.py

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> bootstrap.py

BUG=
==========

to

==========
GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> tools/gn/bootstrap/bootstrap.py

BUG=
==========

[timn, 2016-06-13 07:53:16]

I updated the CL description.

[brettw, 2016-06-13 18:19:44]

Thanks for the decription update, I thought initially this might be targeting
the IDE which made no sense for the bootstrap.

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:136: temp_path = os.path.join(root_gen_dir,
header + '.tmp')
I don't understand this change. Was the tempfile package not working on Windows?
The docs says it works everywhere.

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:276: def write_gn_ninja(path, root_gen_dir,
options):
I don't understand the new distinction you're making between "write_gn_ninja and
"write_ninja". Can the names be changed to reflect what's happening better?

[timn, 2016-06-13 18:56:30]

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:136: temp_path = os.path.join(root_gen_dir,
header + '.tmp')
On 2016/06/13 18:19:43, brettw wrote:
> I don't understand this change. Was the tempfile package not working on
Windows?
> The docs says it works everywhere.

It "works", but not for our use case here.

write_buildflag_header.py needs to open the temp. file, which fails on Windows
because it's still opened by bootstrap.py.

see: http://bugs.python.org/issue14243

https://codereview.chromium.org/2064513002/diff/1/tools/gn/bootstrap/bootstra...
tools/gn/bootstrap/bootstrap.py:276: def write_gn_ninja(path, root_gen_dir,
options):
On 2016/06/13 18:19:43, brettw wrote:
> I don't understand the new distinction you're making between "write_gn_ninja
and
> "write_ninja". Can the names be changed to reflect what's happening better?

write_ninja is just a helper method that does the job of actually writing a
valid build.ninja for a set of inputs (static libraries, executables). 
write_gn_ninja sets up all the targets GN needs and then passes the list to
write_ninja.

How about renaming write_ninja -> write_generic_ninja?

[timn, 2016-06-22 15:54:22]

I renamed write_ninja -> write_generic_ninja and added a few comments to clarify
things.

PTAL

[brettw, 2016-06-29 22:38:01]

Ugh, sorry I haven't gotten to this yet! I've been super backed up.

[brettw, 2016-07-01 18:16:57]

LGTM. Sorry again for the delay.

[timn, 2016-07-01 18:32:41]

The CQ bit was checked by tim@rnc-ag.de

[commit-bot: I haz the power, 2016-07-01 18:33:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 19:23:25]

Description was changed from

==========
GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> tools/gn/bootstrap/bootstrap.py

BUG=
==========

to

==========
GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> tools/gn/bootstrap/bootstrap.py

BUG=
==========

[commit-bot: I haz the power, 2016-07-01 19:23:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 19:23:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 19:26:39]

Description was changed from

==========
GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> tools/gn/bootstrap/bootstrap.py

BUG=
==========

to

==========
GN: Add Windows support to bootstrap.py

Previously GN could only be bootstrapped on Linux/Mac.
This CL adds support for Windows (Visual Studio only at this time).

Note that bootstrap.py expects to be run inside a VS2015 Command Prompt
(i.e. vcvarsall.bat has been run)

Example:
> call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\vc\vcvarsall.bat"
x86
> tools/gn/bootstrap/bootstrap.py

BUG=

Committed: https://crrev.com/3a32f0297bbd2c5673cf02923244ecfeda927b32
Cr-Commit-Position: refs/heads/master@{#403499}
==========

[commit-bot: I haz the power, 2016-07-01 19:26:40]

Patchset 2 (id:??) landed as
https://crrev.com/3a32f0297bbd2c5673cf02923244ecfeda927b32
Cr-Commit-Position: refs/heads/master@{#403499}