Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 206443009: chromeos/dbus: Add fake D-Bus clients for GATT client-mode. (Closed)

Created:
6 years, 9 months ago by armansito
Modified:
6 years, 9 months ago
Reviewers:
keybuk, stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

chromeos/dbus: Add fake D-Bus clients for GATT client-mode. Added fake implementations of GATT service, characteristic, and descriptor clients. A new "Low Energy" fake device is introduced, which uses the fake GATT clients to simulate the Heart Rate Service. BUG=351229 TEST=1. device_unittests, chromeos_unittests. 2. Build and run chrome for Linux with "chromeos=1". Run Bluetooth device discovery, connect to the device named "Bluetooth 4.0 Heart Rate Monitor". Watch the debug output (vmodule="*bluetooth_gatt*=2") for the GATT clients, which should create fake heart rate service and descriptors and update the measurement value at regular intervals. R=keybuk@chromium.org, stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259022

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased & Changed code to create LE device on simulation step 1 and update RSSI on following steps. #

Total comments: 2

Patch Set 3 : Fixed nit. #

Patch Set 4 : Fixed bluetooth_chromeos_unittest #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1039 lines, -10 lines) Patch
M chromeos/chromeos.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 6 chunks +38 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_device_client.cc View 1 2 13 chunks +85 lines, -5 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_characteristic_client.h View 1 chunk +125 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_characteristic_client.cc View 1 chunk +342 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 chunk +57 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_descriptor_client.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_service_client.h View 1 chunk +87 lines, -0 lines 0 comments Download
A chromeos/dbus/fake_bluetooth_gatt_service_client.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.h View 3 chunks +16 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_dbus_thread_manager.cc View 4 chunks +40 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_utils.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
armansito
stevenjb@: rubberstamp for chromeos/dbus/dbus_thread_manager.* and chromeos/dbus/fake_dbus_thread_manager.* keybuk@: All else.
6 years, 9 months ago (2014-03-21 01:30:12 UTC) #1
stevenjb
owner lgtm https://codereview.chromium.org/206443009/diff/1/chromeos/chromeos.gyp File chromeos/chromeos.gyp (right): https://codereview.chromium.org/206443009/diff/1/chromeos/chromeos.gyp#newcode124 chromeos/chromeos.gyp:124: 'dbus/fake_bluetooth_gatt_service_client.h', At this point we really need ...
6 years, 9 months ago (2014-03-21 17:26:05 UTC) #2
keybuk
https://codereview.chromium.org/206443009/diff/1/chromeos/dbus/fake_bluetooth_device_client.cc File chromeos/dbus/fake_bluetooth_device_client.cc (right): https://codereview.chromium.org/206443009/diff/1/chromeos/dbus/fake_bluetooth_device_client.cc#newcode686 chromeos/dbus/fake_bluetooth_device_client.cc:686: dbus::ObjectPath(kLowEnergyPath)); Since this is an LE device, following the ...
6 years, 9 months ago (2014-03-21 19:57:53 UTC) #3
armansito
https://codereview.chromium.org/206443009/diff/1/chromeos/dbus/fake_bluetooth_device_client.cc File chromeos/dbus/fake_bluetooth_device_client.cc (right): https://codereview.chromium.org/206443009/diff/1/chromeos/dbus/fake_bluetooth_device_client.cc#newcode686 chromeos/dbus/fake_bluetooth_device_client.cc:686: dbus::ObjectPath(kLowEnergyPath)); On 2014/03/21 19:57:53, keybuk wrote: > Since this ...
6 years, 9 months ago (2014-03-21 23:18:10 UTC) #4
keybuk
lgtm https://codereview.chromium.org/206443009/diff/20001/chromeos/dbus/fake_bluetooth_device_client.cc File chromeos/dbus/fake_bluetooth_device_client.cc (right): https://codereview.chromium.org/206443009/diff/20001/chromeos/dbus/fake_bluetooth_device_client.cc#newcode680 chromeos/dbus/fake_bluetooth_device_client.cc:680: UpdateDeviceRSSI(dbus::ObjectPath(kLowEnergyPath), base::RandInt(-90, -30)); nit: use constants
6 years, 9 months ago (2014-03-21 23:57:33 UTC) #5
armansito
https://codereview.chromium.org/206443009/diff/20001/chromeos/dbus/fake_bluetooth_device_client.cc File chromeos/dbus/fake_bluetooth_device_client.cc (right): https://codereview.chromium.org/206443009/diff/20001/chromeos/dbus/fake_bluetooth_device_client.cc#newcode680 chromeos/dbus/fake_bluetooth_device_client.cc:680: UpdateDeviceRSSI(dbus::ObjectPath(kLowEnergyPath), base::RandInt(-90, -30)); On 2014/03/21 23:57:33, keybuk wrote: > ...
6 years, 9 months ago (2014-03-22 02:21:59 UTC) #6
armansito
6 years, 9 months ago (2014-03-24 21:51:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r259022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698