Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2064423003: Changing long press timeout 1000ms to 500ms (Closed)

Created:
4 years, 6 months ago by Qiang(Joe) Xu
Modified:
4 years, 6 months ago
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing long press timeout 1000ms to 500ms The long press affordance is removed. Meanwhile, the long press time is still 1000ms which is too long. Change it to 500ms to align with standard. BUG=612890 Committed: https://crrev.com/ecd768b8eaa996dc371c67ffb9c3221808949712 Cr-Commit-Position: refs/heads/master@{#400167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/events/gesture_detection/gesture_configuration.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Qiang(Joe) Xu
Hi, Alexandre, could you help review on this? Thanks!
4 years, 6 months ago (2016-06-16 00:37:35 UTC) #3
aelias_OOO_until_Jul13
It does feel that Chrome/WebView has twice as long long-press delay as Android native apps. ...
4 years, 6 months ago (2016-06-16 00:48:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064423003/1
4 years, 6 months ago (2016-06-16 00:54:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/88470)
4 years, 6 months ago (2016-06-16 02:10:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064423003/1
4 years, 6 months ago (2016-06-16 15:53:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 16:23:04 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 16:23:18 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 16:24:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd768b8eaa996dc371c67ffb9c3221808949712
Cr-Commit-Position: refs/heads/master@{#400167}

Powered by Google App Engine
This is Rietveld 408576698