chrome/browser/notifications/notifier_source.cc - Issue 2064363002: Refactor MessageCenterSettingsController.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/notifications/notifier_source.cc

Issue 2064363002: Refactor MessageCenterSettingsController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unrelated files from the patch. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/notifications/notifier_source.h"

	6

	7 NotifierSource::NotifierSource(message_center::NotifierSettingsObserver* parent)
	dewittj 2016/06/16 19:45:36 Not sure this is totally necessary in the interfac Not sure this is totally necessary in the interface file.. I'd put it on any subclass that requires it. hirono 2016/06/17 04:56:46 Done. Show quoted text On 2016/06/16 19:45:36, dewittj wrote: > Not sure this is totally necessary in the interface file.. I'd put it on any > subclass that requires it. Done.
	8 : parent_(parent) {

	9 DCHECK(parent_);

	10 }

	11

	12 NotifierSource::~NotifierSource() {}

	13

	14 void NotifierSource::OnNotifierSettingsClosing() {}
	dewittj 2016/06/16 19:45:36 this could be inlined in the .h file this could be inlined in the .h file hirono 2016/06/17 04:56:46 Done. Show quoted text On 2016/06/16 19:45:36, dewittj wrote: > this could be inlined in the .h file Done.
OLD	NEW