Move ParseLeftHandSideExpression to ParserBase.

Move ParseLeftHandSideExpression to ParserBase.

Includes cleanups:
- Reorganized functions in PreParserFactory to be in the logical order.
- De-hackified things PreParser doesn't need to track, such as IsCall & IsCallNew.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=20150

[marja, 2014-03-20 16:06:54]

mstarzinger, ptal

https://codereview.chromium.org/206433003/diff/1/src/parser.h
File src/parser.h (left):

https://codereview.chromium.org/206433003/diff/1/src/parser.h#oldcode745
src/parser.h:745: Expression* ParseUnaryExpression(bool* ok);
These are leftover definitions of funcs that have already moved to parserbase.

[Michael Starzinger, 2014-03-21 09:45:43]

LGTM.

https://codereview.chromium.org/206433003/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/206433003/diff/1/src/parser.h#newcode493
src/parser.h:493: void CheckPossibleEvalCall(Expression* expression,
nit: Should fit into one line. Also can we have a short one-line comment about
intended semantics?

[marja, 2014-03-21 09:50:56]

thx for review!

https://codereview.chromium.org/206433003/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/206433003/diff/1/src/parser.h#newcode493
src/parser.h:493: void CheckPossibleEvalCall(Expression* expression,
On 2014/03/21 09:45:44, Michael Starzinger wrote:
> nit: Should fit into one line. Also can we have a short one-line comment about
> intended semantics?

Done.

The comment is:

// Keep track of eval() calls since they disable all local variable
// optimizations. This checks if expression is an eval call, and if yes,
// forwards the information to scope.

[marja, 2014-03-21 09:51:41]

Committed patchset #2 manually as r20150 (presubmit successful).