chrome/browser/ui/views/location_bar/icon_label_bubble_view.h - Issue 2064323005: Change IconLabelBubbleView layout to specify padding beside the separator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 2064323005: Change IconLabelBubbleView layout to specify padding beside the separator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_constants

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

index d6ffdc572c79faf2fb8c11f043996fea39e6e1f9..12a51aa3a30658d070062366e1872d6c7485c1d9 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

@@ -112,9 +112,15 @@ class IconLabelBubbleView : public views::InkDropHostView {

// (or image, if the label is invisible) to the trailing edge of the view.

int GetOuterPadding(bool leading) const;

+ // Horizontal position of the image trailing edge (i.e. just after the image).

+ int GetImageTrailingEdge() const;

// Spacing between the image and the label.

int GetInternalSpacing() const;

+ // Additional width necessary after the label, when the view is at full width.

+ int GetPostLabelWidth() const;

// views::View:

const char* GetClassName() const override;

void OnPaint(gfx::Canvas* canvas) override;