Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2946)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java

Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
index 6a83117efad3de290489f6103c5e971697e07d64..1bfd600f15a34073ff6fbe3c2067a982f063f115 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
@@ -32,7 +32,7 @@ public class BackgroundOfflinerTask {
* @returns true for success
*/
public boolean startBackgroundRequests(Context context, Bundle bundle) {
- processBackgroundRequests(bundle);
+ processBackgroundRequests(bundle, OfflinePageUtils.getDeviceConditions(context));
// Gather UMA data to measure how often the user's machine is amenable to background
// loading when we wake to do a task.
@@ -48,7 +48,7 @@ public class BackgroundOfflinerTask {
// TODO(petewil): Change back to private when UMA works in the test, and test
// startBackgroundRequests instead of this method.
@VisibleForTesting
- public void processBackgroundRequests(Bundle bundle) {
+ public void processBackgroundRequests(Bundle bundle, DeviceConditions deviceConditions) {
// TODO(petewil): Nothing is holding the Wake Lock. We need some solution to
// keep hold of it. Options discussed so far are having a fresh set of functions
// to grab and release a countdown latch, or holding onto the wake lock ourselves,
@@ -69,6 +69,6 @@ public class BackgroundOfflinerTask {
};
// Pass the activation on to the bridge to the C++ RequestCoordinator.
- mBridge.startProcessing(callback);
+ mBridge.startProcessing(deviceConditions, callback);
}
}

Powered by Google App Engine
This is Rietveld 408576698