chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java - Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

Issue 2064323004: Defines initial DeviceConditions and and plumbs down through StartProcessing() call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/StubBackgroundSchedulerProcessor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

index 3ce2f580e2891480db8cf62d0a9eda0387e80cd5..571ade12ce4feeb63eddb1952a3a6051b7de46b3 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.offlinepages;

+import static org.junit.Assert.assertSame;

import static org.junit.Assert.assertTrue;

import android.os.Bundle;

@@ -11,6 +12,7 @@ import android.os.Bundle;

import org.chromium.base.BaseChromiumApplication;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.browser.ChromeBackgroundServiceWaiter;

+import org.chromium.net.ConnectionType;

import org.chromium.testing.local.LocalRobolectricTestRunner;

import org.junit.Before;

import org.junit.Test;

@@ -42,10 +44,13 @@ public class BackgroundOfflinerTaskTest {

BackgroundOfflinerTask task =

new BackgroundOfflinerTask(mStubBackgroundSchedulerProcessor);

ChromeBackgroundServiceWaiter waiter = new ChromeBackgroundServiceWaiter(1);

- task.processBackgroundRequests(mTaskExtras, waiter);

+ DeviceConditions deviceConditions =

+ new DeviceConditions(false, 51, ConnectionType.CONNECTION_WIFI);

+ task.processBackgroundRequests(mTaskExtras, deviceConditions, waiter);

// Check with ShadowBackgroundBackgroundSchedulerProcessor that startProcessing got called.

assertTrue(mStubBackgroundSchedulerProcessor.getStartProcessingCalled());

+ assertSame(deviceConditions, mStubBackgroundSchedulerProcessor.getDeviceConditions());

// TODO(dougarnett): Call processor callback and verify waiter signaled.

}