Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2064293002: Remove unused test code in ~ResourceContext to handle it being destructed on UI threads. (Closed)

Created:
4 years, 6 months ago by jam
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused test code in ~ResourceContext to handle it being destructed on UI threads. The need for this probably went away with TestBrowserThreadBundle. BUG=598073 Committed: https://crrev.com/805952d3dd38258bef32ef7738d3c5e9450ca6e2 Cr-Commit-Position: refs/heads/master@{#399839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/browser/resource_context_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jam
4 years, 6 months ago (2016-06-14 23:25:13 UTC) #3
scottmg
lgtm
4 years, 6 months ago (2016-06-14 23:27:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064293002/1
4 years, 6 months ago (2016-06-15 04:27:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 04:35:58 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 04:36:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 04:41:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/805952d3dd38258bef32ef7738d3c5e9450ca6e2
Cr-Commit-Position: refs/heads/master@{#399839}

Powered by Google App Engine
This is Rietveld 408576698