Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2064233002: MD User Manager: Larger dimensions for the password-separated reauth dialog. (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
Reviewers:
anthonyvd, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Larger dimensions for the password-separated reauth dialog. Gets rid of the unwanted scrollbar in the reauth dialog. BUG=618629 Committed: https://crrev.com/05aabc6c278421aaa055d4a31aac6e63fc8fd8fd Cr-Commit-Position: refs/heads/master@{#400195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/user_manager.h View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/profiles/user_manager_view.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Moe
Hi Anthony, Please review this CL.
4 years, 6 months ago (2016-06-14 20:40:54 UTC) #2
anthonyvd
lgtm
4 years, 6 months ago (2016-06-14 21:03:57 UTC) #3
Moe
Hi Scott, Please review this CL.
4 years, 6 months ago (2016-06-15 12:44:38 UTC) #5
sky
LGTM
4 years, 6 months ago (2016-06-16 16:08:55 UTC) #6
Moe
Thank you.
4 years, 6 months ago (2016-06-16 16:34:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064233002/1
4 years, 6 months ago (2016-06-16 16:35:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 17:50:33 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 17:50:38 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 17:52:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05aabc6c278421aaa055d4a31aac6e63fc8fd8fd
Cr-Commit-Position: refs/heads/master@{#400195}

Powered by Google App Engine
This is Rietveld 408576698