Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2064193002: Use NQE's GetECT() API for data reduction proxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nqe_connection_names
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 33c6c989dd386c489be1a1194e2f0e8a5bf88ef3..576484299f603e75492e43b431c772b5564134ca 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -170,6 +170,11 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// testing.
virtual EffectiveConnectionType GetEffectiveConnectionType() const;
+ // Returns the effective type of the current connection based on only the
+ // samples observed after |start_time|. Virtualized for testing.
+ virtual EffectiveConnectionType GetRecentEffectiveConnectionType(
+ const base::TimeTicks& start_time) const;
+
// Adds |observer| to the list of effective connection type observers. Must be
// called on the IO thread.
void AddEffectiveConnectionTypeObserver(
@@ -416,11 +421,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// current connection type to the observation buffer.
void AddDefaultEstimates();
- // Returns the effective type of the current connection based on only the
- // samples observed after |start_time|.
- EffectiveConnectionType GetRecentEffectiveConnectionType(
- const base::TimeTicks& start_time) const;
-
// Returns an estimate of network quality at the specified |percentile|.
// |disallowed_observation_sources| is the list of observation sources that
// should be excluded when computing the percentile.
« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698