Split out the style-determined direct compositing reasons

Split out the style-determined direct compositing reasons

This CL splits the direct compositing reasons into two groups: those that are
determined from style information alone and those that require some non-style
information. This CL simply separates the two groups. A future CL will move the
computation of the style-determined reasons to recalc style.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169715

[ojan, 2014-03-20 23:56:01]

lgtm

https://codereview.chromium.org/206413009/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/CompositingReasonFinder.cpp (right):

https://codereview.chromium.org/206413009/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/CompositingReasonFinder.cpp:87:
CompositingReasons CompositingReasonFinder::remainingDirectReasons(const
RenderLayer* layer, bool* needToRecomputeCompositingRequirements) const
I think we need a better name for this. Consider in the future where we call the
style one from recalcStyle and this one is called directly from
RenderLayerCompositor. I don't know what to call it though. :)

[abarth-chromium, 2014-03-21 00:04:02]

We discussed nonStyleDeterminedDirectReasons on IRC

[abarth-chromium, 2014-03-21 00:04:13]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:04:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/206413009/20001

[commit-bot: I haz the power, 2014-03-21 00:05:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:05:47]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[abarth-chromium, 2014-03-21 00:23:30]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/206413009/20001

[commit-bot: I haz the power, 2014-03-21 00:36:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:36:12]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[abarth-chromium, 2014-03-21 00:42:20]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-03-21 00:42:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/206413009/20001

[commit-bot: I haz the power, 2014-03-21 01:15:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-21 01:15:02]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[esprehn, 2014-03-21 01:19:42]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-03-21 01:19:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/206413009/20001

[commit-bot: I haz the power, 2014-03-21 02:28:35]

Change committed as 169715