Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: build/common.gypi

Issue 206413006: Use use_allocator instead of android_use_tcmalloc to switch the allocator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit fix Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 11ab19d78be400788248b43dfdcf1f8a0b68eb83..0915c27e60ad2fc077d02f821dfbdaf7cf825818 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1177,11 +1177,12 @@
'release_unwind_tables%': 1,
# Enable TCMalloc.
- # TODO(dmikurube): Change the default of use_allocator to "tcmalloc".
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
+ # TODO(dmikurube): Change Linux default of use_allocator to "tcmalloc".
+ # TODO(dmikurube): Change Android default of use_allocator to "none".
+ # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554
# {linux|android}_use_tcmalloc are to be replaced with use_allocator.
# They are now used only if use_allocator=="see_use_tcmalloc" (default).
- # TODO(dmikurube): Assert when linux_use_tcmalloc is explicitly specified.
+ # TODO(dmikurube): Assert when {linux|android}_use_tcmalloc is explicitly specified.
'linux_use_tcmalloc%': 1,
'android_use_tcmalloc%': 0,
'use_allocator%': 'see_use_tcmalloc',
@@ -3794,8 +3795,8 @@
}],
],
}],
- # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554
- ['(use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or linux_use_tcmalloc==0)) and android_use_tcmalloc==0', {
+ # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/345554
+ ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or ((OS=="linux" and linux_use_tcmalloc==0) or (OS=="android" and android_use_tcmalloc==0)))', {
'defines': ['NO_TCMALLOC'],
}],
['linux_use_gold_flags==1', {
« no previous file with comments | « no previous file | chrome/chrome_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698