Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: build/common.gypi

Issue 206413006: Use use_allocator instead of android_use_tcmalloc to switch the allocator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit fix Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_android.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1159 matching lines...) Expand 10 before | Expand all | Expand 10 after
1170 'linux_dump_symbols%': 0, 1170 'linux_dump_symbols%': 0,
1171 # And if we want to strip the binary after dumping symbols. 1171 # And if we want to strip the binary after dumping symbols.
1172 'linux_strip_binary%': 0, 1172 'linux_strip_binary%': 0,
1173 # Strip the test binaries needed for Linux reliability tests. 1173 # Strip the test binaries needed for Linux reliability tests.
1174 'linux_strip_reliability_tests%': 0, 1174 'linux_strip_reliability_tests%': 0,
1175 # If we want stack unwind support for backtrace(). 1175 # If we want stack unwind support for backtrace().
1176 'debug_unwind_tables%': 1, 1176 'debug_unwind_tables%': 1,
1177 'release_unwind_tables%': 1, 1177 'release_unwind_tables%': 1,
1178 1178
1179 # Enable TCMalloc. 1179 # Enable TCMalloc.
1180 # TODO(dmikurube): Change the default of use_allocator to "tcmalloc". 1180 # TODO(dmikurube): Change Linux default of use_allocator to "tcmalloc".
1181 # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 1181 # TODO(dmikurube): Change Android default of use_allocator to "none".
1182 # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com/34555 4
1182 # {linux|android}_use_tcmalloc are to be replaced with use_allocator. 1183 # {linux|android}_use_tcmalloc are to be replaced with use_allocator.
1183 # They are now used only if use_allocator=="see_use_tcmalloc" (default). 1184 # They are now used only if use_allocator=="see_use_tcmalloc" (default).
1184 # TODO(dmikurube): Assert when linux_use_tcmalloc is explicitly specified. 1185 # TODO(dmikurube): Assert when {linux|android}_use_tcmalloc is explicitly sp ecified.
1185 'linux_use_tcmalloc%': 1, 1186 'linux_use_tcmalloc%': 1,
1186 'android_use_tcmalloc%': 0, 1187 'android_use_tcmalloc%': 0,
1187 'use_allocator%': 'see_use_tcmalloc', 1188 'use_allocator%': 'see_use_tcmalloc',
1188 1189
1189 # Set to 1 to link against libgnome-keyring instead of using dlopen(). 1190 # Set to 1 to link against libgnome-keyring instead of using dlopen().
1190 'linux_link_gnome_keyring%': 0, 1191 'linux_link_gnome_keyring%': 0,
1191 # Set to 1 to link against gsettings APIs instead of using dlopen(). 1192 # Set to 1 to link against gsettings APIs instead of using dlopen().
1192 'linux_link_gsettings%': 0, 1193 'linux_link_gsettings%': 0,
1193 1194
1194 # Default arch variant for MIPS. 1195 # Default arch variant for MIPS.
(...skipping 2592 matching lines...) Expand 10 before | Expand all | Expand 10 after
3787 ['_toolset=="target"', { 3788 ['_toolset=="target"', {
3788 'ldflags': [ 3789 'ldflags': [
3789 # Workaround for linker OOM. 3790 # Workaround for linker OOM.
3790 '-Wl,--no-keep-memory', 3791 '-Wl,--no-keep-memory',
3791 ], 3792 ],
3792 }], 3793 }],
3793 ], 3794 ],
3794 }], 3795 }],
3795 ], 3796 ],
3796 }], 3797 }],
3797 # TODO(dmikurube): Kill linux_use_tcmalloc. http://crbug.com/345554 3798 # TODO(dmikurube): Kill {linux|android}_use_tcmalloc. http://crbug.com /345554
3798 ['(use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or linux_use_tcmalloc==0)) and android_use_tcmalloc==0', { 3799 ['use_allocator!="tcmalloc" and (use_allocator!="see_use_tcmalloc" or ((OS=="linux" and linux_use_tcmalloc==0) or (OS=="android" and android_use_tcmal loc==0)))', {
3799 'defines': ['NO_TCMALLOC'], 3800 'defines': ['NO_TCMALLOC'],
3800 }], 3801 }],
3801 ['linux_use_gold_flags==1', { 3802 ['linux_use_gold_flags==1', {
3802 'target_conditions': [ 3803 'target_conditions': [
3803 ['_toolset=="target"', { 3804 ['_toolset=="target"', {
3804 'ldflags': [ 3805 'ldflags': [
3805 # Experimentation found that using four linking threads 3806 # Experimentation found that using four linking threads
3806 # saved ~20% of link time. 3807 # saved ~20% of link time.
3807 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36 3808 # https://groups.google.com/a/chromium.org/group/chromium-dev/ browse_thread/thread/281527606915bb36
3808 # Only apply this to the target linker, since the host 3809 # Only apply this to the target linker, since the host
(...skipping 1367 matching lines...) Expand 10 before | Expand all | Expand 10 after
5176 # settings in target dicts. SYMROOT is a special case, because many other 5177 # settings in target dicts. SYMROOT is a special case, because many other
5177 # Xcode variables depend on it, including variables such as 5178 # Xcode variables depend on it, including variables such as
5178 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5179 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5179 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5180 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5180 # files to appear (when present) in the UI as actual files and not red 5181 # files to appear (when present) in the UI as actual files and not red
5181 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5182 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5182 # and therefore SYMROOT, needs to be set at the project level. 5183 # and therefore SYMROOT, needs to be set at the project level.
5183 'SYMROOT': '<(DEPTH)/xcodebuild', 5184 'SYMROOT': '<(DEPTH)/xcodebuild',
5184 }, 5185 },
5185 } 5186 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698