Issue 206413005: Visit return statement of inlined function in value context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206413005: Visit return statement of inlined function in value context. (Closed)

Created:
6 years, 9 months ago by ulan

Modified:
6 years, 9 months ago

Reviewers:
danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Visit return statement of inlined function in value context. BUG=354357 LOG=N TEST=mjsunit/regress/regress-354357.js R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20158

Patch Set 3 : Fix comment #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	src/hydrogen.cc	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-354357.js	View	1	1 chunk	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc#newcode4368 src/hydrogen.cc:4368: // (e.g. VisitCountOperation) change the environment depending on ...

6 years, 9 months ago (2014-03-21 09:57:52 UTC) #2

ulan

https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc#newcode4368 src/hydrogen.cc:4368: // (e.g. VisitCountOperation) change the environment depending on context. ...

6 years, 9 months ago (2014-03-21 12:06:17 UTC) #3

ulan

6 years, 9 months ago (2014-03-21 12:14:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r20158 (presubmit successful).

Expand Messages | Collapse Messages

Issue 206413005: Visit return statement of inlined function in value context. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix comment #

Messages