DevTools: minor UI / menu tweaks reducing the clutter.

DevTools: minor UI / menu tweaks reducing the clutter.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169804

[vsevik, 2014-03-20 13:31:08]

https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
File Source/devtools/front_end/ElementsPanel.js (left):

https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
Source/devtools/front_end/ElementsPanel.js:386:
contextMenu.appendCheckboxItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles()
? "Word wrap" : "Word Wrap"), toggleWordWrap,
WebInspector.settings.domWordWrap.get());
Why do you remove it? This might be useful.
Anyway the implementation is still there, isn't it?

[apavlov, 2014-03-21 14:22:54]

https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
File Source/devtools/front_end/ElementsTreeOutline.js (left):

https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
Source/devtools/front_end/ElementsTreeOutline.js:1440:
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles()
? "Inspect DOM properties" : "Inspect DOM Properties"),
this._inspectDOMProperties.bind(this));
This one is also not quite clear to me. It was intended to fix
http://crbug.com/247050. Should we make it WontFix then?

[pfeldman, 2014-03-21 14:48:30]

On 2014/03/20 13:31:08, vsevik wrote:
>
https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
> File Source/devtools/front_end/ElementsPanel.js (left):
> 
>
https://codereview.chromium.org/206413004/diff/1/Source/devtools/front_end/El...
> Source/devtools/front_end/ElementsPanel.js:386:
>
contextMenu.appendCheckboxItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles()
> ? "Word wrap" : "Word Wrap"), toggleWordWrap,
> WebInspector.settings.domWordWrap.get());
> Why do you remove it? This might be useful.
> Anyway the implementation is still there, isn't it?

It is still there in the Settings. Just not something you would toggle often
from the context menu.

[pfeldman, 2014-03-21 14:49:16]

> This one is also not quite clear to me. It was intended to fix
> http://crbug.com/247050. Should we make it WontFix then?

I think so, it sounds like a rarely used feature with a clear workaround to get
into DOM context menu.

[apavlov, 2014-03-21 14:52:39]

On 2014/03/21 14:49:16, pfeldman wrote:
> > This one is also not quite clear to me. It was intended to fix
> > http://crbug.com/247050. Should we make it WontFix then?
> 
> I think so, it sounds like a rarely used feature with a clear workaround to
get
> into DOM context menu.

Makes sense

[apavlov, 2014-03-21 14:52:50]

lgtm

[pfeldman, 2014-03-22 16:44:34]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-03-22 16:44:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/206413004/1

[commit-bot: I haz the power, 2014-03-22 17:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-22 17:24:59]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[pfeldman, 2014-03-22 21:04:09]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-03-22 21:04:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pfeldman@chromium.org/206413004/1

[commit-bot: I haz the power, 2014-03-22 21:44:20]

Change committed as 169804