Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2064073002: Add origin information to trace events for runCompiledScript and callFunction (Closed)

Created:
4 years, 6 months ago by haraken
Modified:
4 years, 5 months ago
Reviewers:
Sami, panicker
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add origin information to trace events for runCompiledScript and callFunction This CL adds "same-origin" or "cross-origin" to trace events for runCompiledScript and callFunction. BUG= Committed: https://crrev.com/cb4aa96be6943a62b6b74aa1954dbf3bbafbf7ff Cr-Commit-Position: refs/heads/master@{#403845}

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
haraken
PTAL I want to visualize the origin info in about:tracing (to understand what scripts are ...
4 years, 6 months ago (2016-06-14 06:15:31 UTC) #2
panicker
lgtm Nice.
4 years, 6 months ago (2016-06-14 16:00:21 UTC) #3
Sami
https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right): https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp#newcode490 third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:490: bool isCrossOrigin = context->isDocument() && toDocument(context)->frame()->isCrossOrigin(); Doesn't frameblamer already ...
4 years, 6 months ago (2016-06-14 22:36:10 UTC) #4
haraken
On 2016/06/14 22:36:10, Sami (slow -- travelling) wrote: > https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp > File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right): > ...
4 years, 6 months ago (2016-06-15 00:14:55 UTC) #5
Sami
Sorry for the delay -- lgtm!
4 years, 6 months ago (2016-06-20 11:07:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2064073002/20001
4 years, 5 months ago (2016-07-04 00:47:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/239534)
4 years, 5 months ago (2016-07-04 01:32:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2064073002/20001
4 years, 5 months ago (2016-07-06 02:20:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 03:59:06 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 03:59:08 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 04:02:44 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb4aa96be6943a62b6b74aa1954dbf3bbafbf7ff
Cr-Commit-Position: refs/heads/master@{#403845}

Powered by Google App Engine
This is Rietveld 408576698