Add origin information to trace events for runCompiledScript and callFunction

Add origin information to trace events for runCompiledScript and callFunction

This CL adds "same-origin" or "cross-origin" to trace events for runCompiledScript and callFunction.

BUG=

Committed: https://crrev.com/cb4aa96be6943a62b6b74aa1954dbf3bbafbf7ff
Cr-Commit-Position: refs/heads/master@{#403845}

[haraken, 2016-06-14 06:15:31]

haraken@chromium.org changed reviewers:
+ panicker@chromium.org, skyostil@chromium.org

[haraken, 2016-06-14 06:15:31]

PTAL

I want to visualize the origin info in about:tracing (to understand what scripts
are invoked by third-party contents).

[panicker, 2016-06-14 16:00:21]

lgtm

Nice.

[Sami, 2016-06-14 22:36:10]

https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):

https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:490: bool
isCrossOrigin = context->isDocument() &&
toDocument(context)->frame()->isCrossOrigin();
Doesn't frameblamer already give us this? The scoped object above ensures we can
find out which url we were executing script for in about:tracing. Maybe we just
need to add the same scope to runCompiledScript?

[haraken, 2016-06-15 00:14:55]

On 2016/06/14 22:36:10, Sami (slow -- travelling) wrote:
>
https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/b...
> File third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp (right):
> 
>
https://codereview.chromium.org/2064073002/diff/1/third_party/WebKit/Source/b...
> third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp:490: bool
> isCrossOrigin = context->isDocument() &&
> toDocument(context)->frame()->isCrossOrigin();
> Doesn't frameblamer already give us this? The scoped object above ensures we
can
> find out which url we were executing script for in about:tracing. Maybe we
just
> need to add the same scope to runCompiledScript?

Ah, right! Done.

[Sami, 2016-06-20 11:07:01]

Sorry for the delay -- lgtm!

[haraken, 2016-07-04 00:47:41]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-07-04 00:47:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
panicker@chromium.org
Link to the patchset: https://codereview.chromium.org/2064073002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-07-04 00:47:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 01:32:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 01:32:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[haraken, 2016-07-06 02:20:45]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-06 02:20:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 03:59:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-06 03:59:08]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-06 04:02:43]

Description was changed from

==========
Add origin information to trace events for runCompiledScript and callFunction

This CL adds "same-origin" or "cross-origin" to trace events for
runCompiledScript and callFunction.

BUG=
==========

to

==========
Add origin information to trace events for runCompiledScript and callFunction

This CL adds "same-origin" or "cross-origin" to trace events for
runCompiledScript and callFunction.

BUG=

Committed: https://crrev.com/cb4aa96be6943a62b6b74aa1954dbf3bbafbf7ff
Cr-Commit-Position: refs/heads/master@{#403845}
==========

[commit-bot: I haz the power, 2016-07-06 04:02:44]

Patchset 2 (id:??) landed as
https://crrev.com/cb4aa96be6943a62b6b74aa1954dbf3bbafbf7ff
Cr-Commit-Position: refs/heads/master@{#403845}