Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 2064023002: S390: Fix arguments object stubs for large arrays. (Closed)

Created:
4 years, 6 months ago by john.yan
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix arguments object stubs for large arrays. Port e95cfafb67dba67eb7c541d97f5e69f8280df771 Original commit message: This fixes FastNewStrictArgumentsStub and FastNewRestParameterStub to no longer assume that the strict arguments object being allocated will fit into new-space. The case where said object needs to move to large object space is now handled in the runtime. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/03bf4dc0fdcd67fc8b5ad6ee92d2550332cf12da Cr-Commit-Position: refs/heads/master@{#36945}

Patch Set 1 #

Patch Set 2 : S390: Fix arguments object stubs for large arrays. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M src/s390/code-stubs-s390.cc View 1 8 chunks +36 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 6 months ago (2016-06-14 00:30:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064023002/20001
4 years, 6 months ago (2016-06-14 00:31:20 UTC) #3
JoranSiu
On 2016/06/14 00:31:20, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 6 months ago (2016-06-14 00:45:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 01:22:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064023002/20001
4 years, 6 months ago (2016-06-14 01:38:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 05:12:07 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 06:12:15 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03bf4dc0fdcd67fc8b5ad6ee92d2550332cf12da
Cr-Commit-Position: refs/heads/master@{#36945}

Powered by Google App Engine
This is Rietveld 408576698