Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2064003002: Fix for issue 26689 - Scrub the function name before storing it in IsolateSpawnState when spawning … (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 26689 - Scrub the function name before storing it in IsolateSpawnState when spawning isolates using the spawn function API. This ensures that we do not place a requirement that the private keys of libraries in a spawned isolate must match the parent isolate. BUG=26689 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/c65ef6a9482dd37fbd040cdea55cbb66456f94f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/vm/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 6 months ago (2016-06-14 00:10:39 UTC) #2
turnidge
lgtm
4 years, 6 months ago (2016-06-14 19:46:34 UTC) #3
siva
4 years, 6 months ago (2016-06-14 21:45:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c65ef6a9482dd37fbd040cdea55cbb66456f94f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698