[Downloads] Fill in the drawer

[Downloads] Fill in the drawer

Current screenshot: https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/view?usp=sharing

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
Committed: https://crrev.com/0d50f320bce6339ef0ede78f69ab17e947b0cb64
Cr-Commit-Position: refs/heads/master@{#401137}

[gone, 2016-06-13 23:54:53]

Description was changed from

==========
[Downloads] Fill in the drawer

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
==========

to

==========
[Downloads] Fill in the drawer

Current screenshot:
https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/vie...

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
==========

[gone, 2016-06-13 23:56:27]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org, nyquist@chromium.org

[gone, 2016-06-13 23:56:28]

nyquist@ for changes to base/

ianwen@ for changes to Downloads UI

[nyquist, 2016-06-14 00:07:04]

//base lgtm

[Ian Wen, 2016-06-16 20:39:22]

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
File chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml:9:
<ImageView
Q: Can we achieve the same effect with TextView and android:drawableStart?

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:64:
StatFs statFs = new StatFs(Environment.getExternalStoragePublicDirectory(
Move it to somewhere else so that we can make it called less often?

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:74:
int percentage = (int) (100.0 * usedBytes / fileSystemBytes);
Nit: maybe add a special case for fileSystemBytes == 0?

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:85:
private static final int[][] FILTER_INFO = new int[][] {
INFO looks like it's not an array. How about FILTERS or FILTER_LIST?

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:97:
private int mSelectedIndex;
Q: the first item is always selected by default, unless the user clicks
something?

[gone, 2016-06-21 18:23:03]

Fought with the NavigationView in Android for a while but:
* I couldn't get it to be styled correctly because of missing attributes in
dummy.package

* Setting colors programatically resulted in no colors being set at all

* The margins are off compared to the mocks

Will revisit when UX gets back to me.

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
File chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/res/layout/download_manager_ui_drawer_filter.xml:9:
<ImageView
On 2016/06/16 20:39:21, Ian Wen wrote:
> Q: Can we achieve the same effect with TextView and android:drawableStart?

Done.

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:64:
StatFs statFs = new StatFs(Environment.getExternalStoragePublicDirectory(
On 2016/06/16 20:39:21, Ian Wen wrote:
> Move it to somewhere else so that we can make it called less often?

Done.

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:74:
int percentage = (int) (100.0 * usedBytes / fileSystemBytes);
On 2016/06/16 20:39:21, Ian Wen wrote:
> Nit: maybe add a special case for fileSystemBytes == 0?

Done.

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:85:
private static final int[][] FILTER_INFO = new int[][] {
On 2016/06/16 20:39:21, Ian Wen wrote:
> INFO looks like it's not an array. How about FILTERS or FILTER_LIST?

Done.

https://chromiumcodereview.appspot.com/2063983002/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:97:
private int mSelectedIndex;
On 2016/06/16 20:39:21, Ian Wen wrote:
> Q: the first item is always selected by default, unless the user clicks
> something?

Not exactly in the spec, but "All downloads" seems like a logical place to
start.

[Ian Wen, 2016-06-21 21:52:05]

lgtm

https://chromiumcodereview.appspot.com/2063983002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:154:
// ImageView iconView = ((ImageView) view.findViewById(R.id.icon));
Oops dead code. :P

[gone, 2016-06-21 21:54:37]

https://chromiumcodereview.appspot.com/2063983002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
(right):

https://chromiumcodereview.appspot.com/2063983002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java:154:
// ImageView iconView = ((ImageView) view.findViewById(R.id.icon));
On 2016/06/21 21:52:05, Ian Wen wrote:
> Oops dead code. :P

Ah, sloppy.  Sorry :(

[gone, 2016-06-21 21:54:44]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-06-21 21:54:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, ianwen@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2063983002/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2016-06-21 21:55:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063983002/60001

[commit-bot: I haz the power, 2016-06-21 23:28:55]

Description was changed from

==========
[Downloads] Fill in the drawer

Current screenshot:
https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/vie...

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
==========

to

==========
[Downloads] Fill in the drawer

Current screenshot:
https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/vie...

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
==========

[commit-bot: I haz the power, 2016-06-21 23:28:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-21 23:30:16]

Description was changed from

==========
[Downloads] Fill in the drawer

Current screenshot:
https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/vie...

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324
==========

to

==========
[Downloads] Fill in the drawer

Current screenshot:
https://drive.google.com/a/google.com/file/d/0B7c8ZkXVwskDd1pocmo5dUdHcG8/vie...

* Add a pair of methods to ApiCompatibilityUtils for
  grabbing storage size information.

* Add a small widget for displaying how much space is used
  compared to how large storage is.

* Add a way to select a filter for the downloads.  It's not
  currently hooked up to anything.

* Add a bunch of icons for the sections.

BUG=616324

Committed: https://crrev.com/0d50f320bce6339ef0ede78f69ab17e947b0cb64
Cr-Commit-Position: refs/heads/master@{#401137}
==========

[commit-bot: I haz the power, 2016-06-21 23:30:17]

Patchset 4 (id:??) landed as
https://crrev.com/0d50f320bce6339ef0ede78f69ab17e947b0cb64
Cr-Commit-Position: refs/heads/master@{#401137}