Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2063933002: Always capture instantiator in async functions (Closed)

Created:
4 years, 6 months ago by hausner
Modified:
4 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Always capture instantiator in async functions Simplifies the VM code a bit. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/3e9b9615c03ecbdb1565aa75536821ca0c673d56

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'master' into instant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M runtime/vm/parser.cc View 1 3 chunks +36 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 6 months ago (2016-06-13 22:34:58 UTC) #3
regis
LGTM https://codereview.chromium.org/2063933002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2063933002/diff/1/runtime/vm/parser.cc#newcode6825 runtime/vm/parser.cc:6825: // Capture instantiator in case it is needed ...
4 years, 6 months ago (2016-06-13 22:38:23 UTC) #4
hausner
4 years, 6 months ago (2016-06-14 18:03:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
3e9b9615c03ecbdb1565aa75536821ca0c673d56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698