Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2063883002: Revert of Add samples to Viewer. (Closed)

Created:
4 years, 6 months ago by egdaniel
Modified:
4 years, 6 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add samples to Viewer. (patchset #4 id:60001 of https://codereview.chromium.org/2056343004/ ) Reason for revert: breaking on android compile Original issue's description: > Add samples to Viewer. > > This adds support with animation, assuming the sample has > implemented onAnimate. Event handling has not been > implemented. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004 > > Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658 TBR=bsalomon@google.com,jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f533f116e6324ee8592fbb49b8fca096c7fe926e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -224 lines) Patch
M gyp/viewer.gyp View 2 chunks +2 lines, -118 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M samplecode/SampleAtlas.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M samplecode/SampleClock.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/viewer/SKPSlide.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/viewer/SKPSlide.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tools/viewer/SampleSlide.h View 1 chunk +0 lines, -34 lines 0 comments Download
D tools/viewer/SampleSlide.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M tools/viewer/Slide.h View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/viewer/Viewer.cpp View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
egdaniel
Created Revert of Add samples to Viewer.
4 years, 6 months ago (2016-06-13 18:28:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063883002/1
4 years, 6 months ago (2016-06-13 18:29:11 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 18:30:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f533f116e6324ee8592fbb49b8fca096c7fe926e

Powered by Google App Engine
This is Rietveld 408576698