MD Settings: Hook up about_page to new LifetimeBrowserProxy.

MD Settings: Hook up about_page to new LifetimeBrowserProxy.

BUG=617830, 546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/58f27774b5ae565859801b7039349f8621e786cb
Cr-Commit-Position: refs/heads/master@{#400033}

[dpapad, 2016-06-14 20:31:32]

Description was changed from

==========
MD Settings: Hook up about_page to new LifetimeBrowserProxy.

BUG=617830,546841
==========

to

==========
MD Settings: Hook up about_page to new LifetimeBrowserProxy.

BUG=617830,546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-14 21:50:07]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-06-15 16:02:35]

lgtm sans below nit:

https://codereview.chromium.org/2063873004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/about_page_tests.js (right):

https://codereview.chromium.org/2063873004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/about_page_tests.js:148: var aboutBrowserProxy =
null;
nit: in about_page.js this is just called browserProxy, whereas here it's named
more specifically as aboutBrowserProxy.

[dpapad, 2016-06-15 17:30:19]

https://codereview.chromium.org/2063873004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/about_page_tests.js (right):

https://codereview.chromium.org/2063873004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/about_page_tests.js:148: var aboutBrowserProxy =
null;
On 2016/06/15 at 16:02:35, tommycli wrote:
> nit: in about_page.js this is just called browserProxy, whereas here it's
named more specifically as aboutBrowserProxy.

Done, renamed it accordingly in about_page.js.

[dpapad, 2016-06-15 17:30:29]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-15 17:30:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2063873004/#ps40001
(title: "Rename nit.")

[commit-bot: I haz the power, 2016-06-15 17:30:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063873004/40001

[commit-bot: I haz the power, 2016-06-15 17:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 17:51:28]

Try jobs failed on following builders:
  closure_compilation on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2016-06-15 19:41:45]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-15 19:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2063873004/#ps60001
(title: "Fix Closure compilation.")

[commit-bot: I haz the power, 2016-06-15 19:42:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063873004/60001

[commit-bot: I haz the power, 2016-06-15 20:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 20:30:28]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[dpapad, 2016-06-15 22:40:47]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-06-15 22:41:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063873004/60001

[commit-bot: I haz the power, 2016-06-15 22:50:40]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-15 22:50:54]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 22:51:51]

Description was changed from

==========
MD Settings: Hook up about_page to new LifetimeBrowserProxy.

BUG=617830,546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hook up about_page to new LifetimeBrowserProxy.

BUG=617830,546841
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/58f27774b5ae565859801b7039349f8621e786cb
Cr-Commit-Position: refs/heads/master@{#400033}
==========

[commit-bot: I haz the power, 2016-06-15 22:51:52]

Patchset 4 (id:??) landed as
https://crrev.com/58f27774b5ae565859801b7039349f8621e786cb
Cr-Commit-Position: refs/heads/master@{#400033}