Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: chrome/browser/printing/print_job_manager.cc

Issue 2063863002: Use DCHECKs when observing only a single notification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job.cc ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_manager.cc
diff --git a/chrome/browser/printing/print_job_manager.cc b/chrome/browser/printing/print_job_manager.cc
index 19b2b8f787ef430d7561dac2dc77104d08dd2671..c47cdb09a32c5bf306b859f1fa951ca178a953fd 100644
--- a/chrome/browser/printing/print_job_manager.cc
+++ b/chrome/browser/printing/print_job_manager.cc
@@ -112,17 +112,10 @@ void PrintJobManager::Observe(int type,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- switch (type) {
- case chrome::NOTIFICATION_PRINT_JOB_EVENT: {
- OnPrintJobEvent(content::Source<PrintJob>(source).ptr(),
- *content::Details<JobEventDetails>(details).ptr());
- break;
- }
- default: {
- NOTREACHED();
- break;
- }
- }
+ DCHECK_EQ(chrome::NOTIFICATION_PRINT_JOB_EVENT, type);
+
+ OnPrintJobEvent(content::Source<PrintJob>(source).ptr(),
+ *content::Details<JobEventDetails>(details).ptr());
}
void PrintJobManager::OnPrintJobEvent(
« no previous file with comments | « chrome/browser/printing/print_job.cc ('k') | chrome/browser/printing/print_view_manager_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698