Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2063853002: Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) (Closed)

Created:
4 years, 6 months ago by fmeawad
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. The original CL was failing the TSAN builder, the variable in question was intended to be accessed quickly with no guarantee. Switched to using an Atomic variable with no barrier read/write. BUG=v8:5089 patch from issue 2052523002 at patchset 100001 (http://crrev.com/2052523002#ps100001) Committed: https://crrev.com/fd7080cbefc21f2f890b5db00d4eadf163e2cbbf Cr-Commit-Position: refs/heads/master@{#36973}

Patch Set 1 #

Patch Set 2 : The reland fix: Use an atomic variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M src/api.cc View 10 chunks +11 lines, -0 lines 0 comments Download
M src/api-arguments.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/api-arguments-inl.h View 1 5 chunks +5 lines, -0 lines 0 comments Download
M src/counters.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M src/tracing/trace-event.h View 1 2 chunks +28 lines, -0 lines 0 comments Download
M src/tracing/trace-event.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fmeawad
Hi cbruni, Patch #1 has the changes for the reland. PTAL
4 years, 6 months ago (2016-06-13 19:03:41 UTC) #2
Camillo Bruni
lgtm
4 years, 6 months ago (2016-06-14 08:27:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063853002/20001
4 years, 6 months ago (2016-06-14 14:57:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 15:03:23 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fd7080cbefc21f2f890b5db00d4eadf163e2cbbf Cr-Commit-Position: refs/heads/master@{#36973}
4 years, 6 months ago (2016-06-14 15:05:18 UTC) #8
Michael Achenbach
4 years, 6 months ago (2016-06-15 11:43:37 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2068143002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for
http://crbug.com/620279.

Powered by Google App Engine
This is Rietveld 408576698