Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 206383003: Callers of JSArray::SetContent() handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Callers of JSArray::SetContent() handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20128

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -39 lines) Patch
M src/runtime.cc View 5 chunks +30 lines, -39 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-20 12:47:54 UTC) #1
Yang
LGTM with suggestion. https://codereview.chromium.org/206383003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101 src/runtime.cc:13101: isolate->factory()->SetContent(Handle<JSArray>::cast(result), instances); for the sake of ...
6 years, 9 months ago (2014-03-20 13:22:07 UTC) #2
Igor Sheludko
https://codereview.chromium.org/206383003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101 src/runtime.cc:13101: isolate->factory()->SetContent(Handle<JSArray>::cast(result), instances); On 2014/03/20 13:22:07, Yang wrote: > for ...
6 years, 9 months ago (2014-03-20 13:28:13 UTC) #3
Yang
On 2014/03/20 13:28:13, Igor Sheludko wrote: > https://codereview.chromium.org/206383003/diff/1/src/runtime.cc > File src/runtime.cc (right): > > https://codereview.chromium.org/206383003/diff/1/src/runtime.cc#newcode13101 ...
6 years, 9 months ago (2014-03-20 13:29:09 UTC) #4
Igor Sheludko
6 years, 9 months ago (2014-03-20 13:40:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20128 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698