Issue 206383002: Revert "Throw exception on invalid string length instead of OOM."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206383002: Revert "Throw exception on invalid string length instead of OOM." (Closed)

Created:
6 years, 9 months ago by Yang

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Throw exception on invalid string length instead of OOM." This reverts r20112. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20114

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -210 lines)			Patch
M	src/api.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/func-name-inferrer.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/json-stringifier.h	View	7 chunks	+6 lines, -29 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	19 chunks	+47 lines, -44 lines	0 comments	Download
M	src/uri.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/test-strings.cc	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/mjsunit/string-oom-array-join.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	test/mjsunit/string-oom-concat.js	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	test/mjsunit/string-oom-replace-global-regexp-with-string.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	test/mjsunit/string-oom-replace-regexp-global-with-function.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	test/mjsunit/string-oom-slow-escape.js	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	test/mjsunit/string-oom-slow-json-stringify.js	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	test/mjsunit/string-oom-slow-replace-one-with-string.js	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	test/mjsunit/string-oom-slow-to-uppercase.js	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r20114.

Expand Messages | Collapse Messages