Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2063803002: Reenable WebGL Image Chromium. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, f(malita), jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, dshwang, blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WebGL Image Chromium. The feature was disabled because of two bugs. Both have since been fixed. BUG=617249, 581777 Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 Cr-Commit-Position: refs/heads/master@{#399625}

Patch Set 1 #

Patch Set 2 : Reenable WebGL Image CHROMIUM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
erikchen
piman: Please review.
4 years, 6 months ago (2016-06-13 17:24:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063803002/20001
4 years, 6 months ago (2016-06-13 17:24:14 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 6 months ago (2016-06-13 17:31:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 18:43:51 UTC) #8
piman
lgtm
4 years, 6 months ago (2016-06-14 00:23:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063803002/20001
4 years, 6 months ago (2016-06-14 00:41:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 00:46:09 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 Cr-Commit-Position: refs/heads/master@{#399625}
4 years, 6 months ago (2016-06-14 00:48:54 UTC) #14
erikchen
4 years, 6 months ago (2016-06-14 20:43:55 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2065073003/ by erikchen@chromium.org.

The reason for reverting is: Breaks 2 conformance tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=620067

https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%....

Powered by Google App Engine
This is Rietveld 408576698