Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2063773002: Reland: WTF: Implement explicit RefPtr::operator bool. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
Nico
CC:
jbroman, ajuma+watch_chromium.org, ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gavinp+loader_chromium.org, Nate Chapin, jchaffraix+rendering, Justin Novosad, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, Mikhail, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: WTF: Implement explicit RefPtr::operator bool. This is the modern alternative to the "safe bool" idiom. Some changes at call sites are required, primarily because returning a boolean does not cause an explicit conversion. This is a reland of https://codereview.chromium.org/1891473002/ with no changes aside from a rebase. There should be no more performance impact after the fix in bug 607208. BUG=607208 Committed: https://crrev.com/70843029b30a2566640848f072312cde61954ed3 Cr-Commit-Position: refs/heads/master@{#399979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/SubstituteData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODRedBlackTree.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 3 chunks +23 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 3 chunks +23 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbroman
OK, the memchr CL seems to be sticking now (knock on wood), so I'd like ...
4 years, 6 months ago (2016-06-15 13:59:56 UTC) #3
Nico
lgtm (i checked if "Recommendations for explicit conversion operator call-sites" on chromium-dev had any conclusion…doesn't ...
4 years, 6 months ago (2016-06-15 14:02:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063773002/1
4 years, 6 months ago (2016-06-15 14:28:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 18:55:03 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 18:55:21 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 18:57:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70843029b30a2566640848f072312cde61954ed3
Cr-Commit-Position: refs/heads/master@{#399979}

Powered by Google App Engine
This is Rietveld 408576698