Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2063763002: [ios] Removed deprecated ios/web/test/web_test.h. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed deprecated ios/web/test/web_test.h. This header was split into 3 separate headers: ios/web/public/test/web_test.h ios/web/public/test/web_test_with_web_state.h ios/web/test/web_test_with_web_controller.h BUG=619076 Committed: https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974 Cr-Commit-Position: refs/heads/master@{#399554}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Actually removed web_test.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -163 lines) Patch
M ios/web/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/active_state_manager_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/ios_web.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/net/crw_cert_verification_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/public/test/web_test_with_web_state.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/test/web_int_test.h View 1 chunk +1 line, -1 line 0 comments Download
D ios/web/test/web_test.h View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/web_state/js/common_js_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/js/core_js_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_manager_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/web_state/js/crw_js_post_request_loader_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/page_script_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_observer_unittest.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 31 chunks +120 lines, -118 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/web_view_js_utils_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/webui/mojo_facade_unittest.mm View 1 chunk +4 lines, -1 line 0 comments Download
M ios/web/webui/web_ui_mojo_inttest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063763002/1
4 years, 6 months ago (2016-06-13 16:10:46 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/20129) ios-device-gn on ...
4 years, 6 months ago (2016-06-13 16:13:17 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063763002/20001
4 years, 6 months ago (2016-06-13 16:33:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 17:31:08 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063763002/40001
4 years, 6 months ago (2016-06-13 20:10:35 UTC) #10
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-13 20:10:49 UTC) #12
kkhorimoto
lgtm
4 years, 6 months ago (2016-06-13 20:42:42 UTC) #13
Eugene But (OOO till 7-30)
Thanks!
4 years, 6 months ago (2016-06-13 21:28:56 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 21:35:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063763002/40001
4 years, 6 months ago (2016-06-13 21:38:13 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 21:46:10 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:48:29 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/deaa82317a3c0acb6357a65a51128cebbcf9c974
Cr-Commit-Position: refs/heads/master@{#399554}

Powered by Google App Engine
This is Rietveld 408576698