Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 206373007: Pull GN binary at r258987 (Closed)

Created:
6 years, 9 months ago by brettw
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

This renames all custom GN targets to actions in the GN build like the new version requires. R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259610

Patch Set 1 #

Patch Set 2 : pull binary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/util/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/bin/linux/gn.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/linux/gn32.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/mac/gn.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/win/gn.exe.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/device/usb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/tools/grit/grit_rule.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 9 months ago (2014-03-24 20:18:23 UTC) #1
scottmg
lgtm
6 years, 9 months ago (2014-03-25 00:25:36 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 9 months ago (2014-03-25 04:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/206373007/20001
6 years, 9 months ago (2014-03-25 04:53:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 04:53:21 UTC) #5
commit-bot: I haz the power
Failed to apply patch for build/util/BUILD.gn: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-25 04:53:21 UTC) #6
brettw
6 years, 9 months ago (2014-03-26 17:04:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r259610 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698