Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 206373006: Rename IntRectExtent to IntBoxExtent (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jbroman, danakj, Rik, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink
Visibility:
Public.

Description

Rename IntRectExtent to IntBoxExtent Rename the IntRectExtent class to IntBoxExtent to match the naming of the LayoutUnit and floating point versions of the same concept. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -123 lines) Patch
M Source/core/rendering/FilterEffectRenderer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/geometry/IntBoxExtent.h View 5 chunks +9 lines, -9 lines 0 comments Download
D Source/platform/geometry/IntRectExtent.h View 1 chunk +0 lines, -109 lines 0 comments Download
M Source/platform/graphics/filters/FilterOperations.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eae
6 years, 9 months ago (2014-03-20 17:33:41 UTC) #1
leviw_travelin_and_unemployed
Okay. LGTM.
6 years, 9 months ago (2014-03-20 18:02:33 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-20 18:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/206373006/1
6 years, 9 months ago (2014-03-20 18:05:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 18:11:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-20 18:11:48 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-20 18:14:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/206373006/1
6 years, 9 months ago (2014-03-20 18:14:36 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 19:00:48 UTC) #9
Message was sent while issue was closed.
Change committed as 169675

Powered by Google App Engine
This is Rietveld 408576698