Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2063693002: [builtins] Introduce proper Float64Log2 and Float64Log10 operators. (Closed)

Created:
4 years, 6 months ago by mvstanton
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper Float64Log2 and Float64Log10 operators. BUG=v8:5095 Committed: https://crrev.com/d9bf520a22924381a1da7e85d5d0063245a3c6c1 Cr-Commit-Position: refs/heads/master@{#37035}

Patch Set 1 #

Patch Set 2 : Improvements #

Patch Set 3 : Ports. #

Patch Set 4 : REBASE. #

Patch Set 5 : Use more precise version of log2. #

Patch Set 6 : REBASE. #

Patch Set 7 : More precise log10. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+546 lines, -186 lines) Patch
M src/assembler.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/base/ieee754.cc View 1 2 3 4 5 6 2 chunks +302 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 3 4 5 2 chunks +28 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +0 lines, -183 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mvstanton
Hi Benedikt, here is the implementation we discussed. PTAL, thx! --Mike
4 years, 6 months ago (2016-06-14 12:08:14 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-16 11:19:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063693002/120001
4 years, 6 months ago (2016-06-16 11:19:40 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-16 11:22:41 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 11:25:16 UTC) #10
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/d9bf520a22924381a1da7e85d5d0063245a3c6c1
Cr-Commit-Position: refs/heads/master@{#37035}

Powered by Google App Engine
This is Rietveld 408576698