Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1978)

Unified Diff: ash/common/system/chromeos/power/power_status.h

Issue 2063633002: Render Ash material design battery image icon without PNGs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add battery percentage constant Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/system/chromeos/power/power_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/chromeos/power/power_status.h
diff --git a/ash/common/system/chromeos/power/power_status.h b/ash/common/system/chromeos/power/power_status.h
index 26c4b1947ad5f8b34cf4c6feb463cbadbba7a480..b9e3d8345961d77601487ab223d6bd01dc0e8f72 100644
--- a/ash/common/system/chromeos/power/power_status.h
+++ b/ash/common/system/chromeos/power/power_status.h
@@ -24,6 +24,15 @@ namespace ash {
// available to interested classes within Ash.
class ASH_EXPORT PowerStatus : public chromeos::PowerManagerClient::Observer {
public:
+ // Types of badges which can be drawn on top of a battery icon.
+ enum IconBadge {
+ ICON_BADGE_NONE,
+ ICON_BADGE_ALERT,
+ ICON_BADGE_BOLT,
+ ICON_BADGE_X,
+ ICON_BADGE_UNRELIABLE
+ };
+
// Different styles of battery icons.
enum IconSet {
ICON_LIGHT,
@@ -67,24 +76,40 @@ class ASH_EXPORT PowerStatus : public chromeos::PowerManagerClient::Observer {
// updating onscreen icons (GetBatteryImage() creates a new image on each
// call).
struct BatteryImageInfo {
- BatteryImageInfo() : resource_id(-1), offset(-1), index(-1) {}
+ BatteryImageInfo()
+ : resource_id(-1),
+ offset(-1),
+ index(-1),
+ icon_badge(ICON_BADGE_NONE),
+ charge_level(-1) {}
+
+ bool operator==(const BatteryImageInfo& o) const;
- bool operator==(const BatteryImageInfo& o) const {
- return resource_id == o.resource_id && offset == o.offset &&
- index == o.index;
- }
bool operator!=(const BatteryImageInfo& o) const { return !(*this == o); }
// Resource ID of the image containing the specific battery icon to use.
+ // Only used in non-MD.
int resource_id;
// Horizontal offset in the battery icon array image. The USB / "unreliable
// charging" image has a single column of icons; the other image contains a
// "battery" column on the left and a "line power" column on the right.
+ // Only used in non-MD.
int offset;
- // Vertical offset corresponding to the current battery level.
+ // Vertical offset corresponding to the current battery level. Only used in
+ // non-MD.
int index;
+
+ // The badge (lightning bolt, exclamation mark, etc) that should be drawn
+ // on top of the battery icon. Only used for MD.
+ // TODO(tdanderson): Consider using gfx::VectorIconId instead of this enum
+ // once all possible badges have been vectorized. See crbug.com/617298.
+ IconBadge icon_badge;
+
+ // A value between 0 and kBatteryImageHeightMD representing the height
+ // of the battery's charge level in dp. Only used for MD.
+ int charge_level;
};
// Maximum battery time-to-full or time-to-empty that should be displayed
@@ -92,6 +117,11 @@ class ASH_EXPORT PowerStatus : public chromeos::PowerManagerClient::Observer {
// get very large; avoid displaying these large numbers.
static const int kMaxBatteryTimeToDisplaySec;
+ // An alert badge is drawn over the material design battery icon if the
+ // battery is not connected to a charger and has less than
+ // |kCriticalBatteryChargePercentageMd| percentage of charge remaining.
+ static const double kCriticalBatteryChargePercentageMd;
+
// Sets the global instance. Must be called before any calls to Get().
static void Initialize();
@@ -193,8 +223,23 @@ class ASH_EXPORT PowerStatus : public chromeos::PowerManagerClient::Observer {
// returned by this method to avoid creating new images unnecessarily.
BatteryImageInfo GetBatteryImageInfo(IconSet icon_set) const;
+ // A helper function called by GetBatteryImageInfo(). Populates the
+ // MD-specific fields of |info|.
+ void CalculateBatteryImageInfoMd(BatteryImageInfo* info) const;
+
+ // A helper function called by GetBatteryImageInfo(). Populates the
+ // non-MD-specific fields of |info|.
+ void CalculateBatteryImageInfoNonMd(BatteryImageInfo* info,
+ const IconSet& icon_set) const;
+
// Creates a new image that should be shown for the battery's current state.
- gfx::ImageSkia GetBatteryImage(IconSet icon_set) const;
+ gfx::ImageSkia GetBatteryImage(const BatteryImageInfo& info) const;
+
+ // A version of GetBatteryImage() that is used when material design is not
+ // enabled.
+ // TODO(tdanderson): Remove this once material design is enabled by default.
+ // See crbug.com/614453.
+ gfx::ImageSkia GetBatteryImageNonMd(const BatteryImageInfo& info) const;
// Returns an string describing the current state for accessibility.
base::string16 GetAccessibleNameString(bool full_description) const;
« no previous file with comments | « no previous file | ash/common/system/chromeos/power/power_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698