Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2063623003: MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes Fixes the bug where elements with "hidden" attr were still displaying. Styles for the "hidden" attr are in "iron-positioning" module. BUG=619466 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b Cr-Commit-Position: refs/heads/master@{#399516}

Patch Set 1 #

Messages

Total messages: 14 (4 generated)
Moe
Hi Demetrios, Please review this CL.
4 years, 6 months ago (2016-06-13 15:39:25 UTC) #3
dpapad
I am surprised that this problem has not come up in other Polymer code, like ...
4 years, 6 months ago (2016-06-13 17:59:06 UTC) #4
michaelpg
On 2016/06/13 17:59:06, dpapad wrote: > I am surprised that this problem has not come ...
4 years, 6 months ago (2016-06-13 18:02:20 UTC) #5
dpapad
On 2016/06/13 at 18:02:20, michaelpg wrote: > On 2016/06/13 17:59:06, dpapad wrote: > > I ...
4 years, 6 months ago (2016-06-13 18:07:53 UTC) #6
Moe
On 2016/06/13 18:07:53, dpapad wrote: > On 2016/06/13 at 18:02:20, michaelpg wrote: > > On ...
4 years, 6 months ago (2016-06-13 18:28:21 UTC) #7
Moe
Thank you!
4 years, 6 months ago (2016-06-13 18:28:46 UTC) #8
Moe
Thank you!
4 years, 6 months ago (2016-06-13 18:28:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063623003/1
4 years, 6 months ago (2016-06-13 18:29:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 20:06:44 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:08:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b
Cr-Commit-Position: refs/heads/master@{#399516}

Powered by Google App Engine
This is Rietveld 408576698