MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG=619466
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b
Cr-Commit-Position: refs/heads/master@{#399516}

[Moe, 2016-06-13 15:38:53]

Description was changed from

==========
MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG=619466
==========

to

==========
MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG=619466
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-06-13 15:39:24]

mahmadi@chromium.org changed reviewers:
+ dpapad@chromium.org

[Moe, 2016-06-13 15:39:25]

Hi Demetrios, Please review this CL.

[dpapad, 2016-06-13 17:59:06]

I am surprised that this problem has not come up in other Polymer code, like in
MD settings. Are you sure that the issue is not fixed by changing
hidden="[[...]]" to hidden$="[[...]]" instead? See examples,
https://cs.chromium.org/search/?q=%22hidden$%3D%22+file:%5Esrc/chrome/browser...
and documentation at
https://www.polymer-project.org/1.0/docs/devguide/data-binding#attribute-binding.

The browser by default includes the appropriate styles for the "hidden"
attribute AFAIK, no need for polymer styles.

[michaelpg, 2016-06-13 18:02:20]

On 2016/06/13 17:59:06, dpapad wrote:
> I am surprised that this problem has not come up in other Polymer code, like
in
> MD settings. Are you sure that the issue is not fixed by changing
> hidden="[[...]]" to hidden$="[[...]]" instead? See examples,
>
https://cs.chromium.org/search/?q=%22hidden$%3D%22+file:%5Esrc/chrome/browser...
> and documentation at
>
https://www.polymer-project.org/1.0/docs/devguide/data-binding#attribute-binding.
> 
> The browser by default includes the appropriate styles for the "hidden"
> attribute AFAIK, no need for polymer styles.

the browser user agent includes:

    [hidden] { display: none }

we often do:

    #foo { display: flex; }

which has higher specificity. this is why developers generally do:

    [hidden] { display: none !important; }
                             ^^^^^^^^^^

which is what iron-positioning has.

[dpapad, 2016-06-13 18:07:53]

On 2016/06/13 at 18:02:20, michaelpg wrote:
> On 2016/06/13 17:59:06, dpapad wrote:
> > I am surprised that this problem has not come up in other Polymer code, like
in
> > MD settings. Are you sure that the issue is not fixed by changing
> > hidden="[[...]]" to hidden$="[[...]]" instead? See examples,
> >
https://cs.chromium.org/search/?q=%22hidden$%3D%22+file:%5Esrc/chrome/browser...
> > and documentation at
> >
https://www.polymer-project.org/1.0/docs/devguide/data-binding#attribute-binding.
> > 
> > The browser by default includes the appropriate styles for the "hidden"
> > attribute AFAIK, no need for polymer styles.
> 
> the browser user agent includes:
> 
>     [hidden] { display: none }
> 
> we often do:
> 
>     #foo { display: flex; }
> 
> which has higher specificity. this is why developers generally do:
> 
>     [hidden] { display: none !important; }
>                              ^^^^^^^^^^
> 
> which is what iron-positioning has.

Thanks for the explanation, LGTM.

[Moe, 2016-06-13 18:28:21]

On 2016/06/13 18:07:53, dpapad wrote:
> On 2016/06/13 at 18:02:20, michaelpg wrote:
> > On 2016/06/13 17:59:06, dpapad wrote:
> > > I am surprised that this problem has not come up in other Polymer code,
like
> in
> > > MD settings. Are you sure that the issue is not fixed by changing
> > > hidden="[[...]]" to hidden$="[[...]]" instead? See examples,
> > >
>
https://cs.chromium.org/search/?q=%22hidden$%3D%22+file:%5Esrc/chrome/browser...
> > > and documentation at
> > >
>
https://www.polymer-project.org/1.0/docs/devguide/data-binding#attribute-binding.
> > > 
> > > The browser by default includes the appropriate styles for the "hidden"
> > > attribute AFAIK, no need for polymer styles.
> > 
> > the browser user agent includes:
> > 
> >     [hidden] { display: none }
> > 
> > we often do:
> > 
> >     #foo { display: flex; }
> > 
> > which has higher specificity. this is why developers generally do:
> > 
> >     [hidden] { display: none !important; }
> >                              ^^^^^^^^^^
> > 
> > which is what iron-positioning has.
> 
> Thanks for the explanation, LGTM.

looks like Michael was quicker than me in answering that. The reason you're not
noticing this in the settings is probably the way iron-flex-layout is imported.
You must be ignoring some console warnings. I also remember Dan advising against
native attribute bindings in Chromium when it is possible to use property
bindings (e.g., "hidden").

[Moe, 2016-06-13 18:28:46]

Thank you!

[Moe, 2016-06-13 18:28:46]

Thank you!

[Moe, 2016-06-13 18:28:52]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-06-13 18:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063623003/1

[commit-bot: I haz the power, 2016-06-13 20:06:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-13 20:08:04]

Description was changed from

==========
MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG=619466
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MDUserManager: import the appropriate dom-modules form iron-flex-layout-classes

Fixes the bug where elements with "hidden" attr were still displaying.
Styles for the "hidden" attr are in "iron-positioning" module.

BUG=619466
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b
Cr-Commit-Position: refs/heads/master@{#399516}
==========

[commit-bot: I haz the power, 2016-06-13 20:08:05]

Patchset 1 (id:??) landed as
https://crrev.com/9de5b1233eab1d73a43be8818a5af3d520e41b4b
Cr-Commit-Position: refs/heads/master@{#399516}