Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2063623002: [Chromoting] Log mouse events in remoting_key_tester (Closed)

Created:
4 years, 6 months ago by Hzj_jie
Modified:
4 years, 6 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Log mouse events in remoting_key_tester We have received a bug to complain scrolling moves in only one direction when zooming with CAD tools in chromoting from Mac to Windows. This issue won't reproduce on Linux client, so a potential Mac PNACL implementation defect could be the root cause. So this change logs mouse related events in remoting_key_tester to help debugging on Mac. BUG= Committed: https://crrev.com/55492620e9b09c593cd353b2a9f77317a4837d7f Cr-Commit-Position: refs/heads/master@{#399525}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Resolve review comments -- Remove LogToConsole(s). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -12 lines) Patch
M remoting/tools/javascript_key_tester/event_listeners.js View 2 chunks +8 lines, -5 lines 0 comments Download
M remoting/tools/javascript_key_tester/main.css View 2 chunks +8 lines, -2 lines 0 comments Download
M remoting/tools/javascript_key_tester/main.html View 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc View 1 4 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Hzj_jie
4 years, 6 months ago (2016-06-12 19:31:30 UTC) #3
Jamie
lgtm https://codereview.chromium.org/2063623002/diff/1/remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc File remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc (right): https://codereview.chromium.org/2063623002/diff/1/remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc#newcode23 remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc:23: LogToConsole(PP_LOGLEVEL_LOG, I don't think you want LogToConsole here. ...
4 years, 6 months ago (2016-06-13 17:25:42 UTC) #4
Hzj_jie
https://codereview.chromium.org/2063623002/diff/1/remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc File remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc (right): https://codereview.chromium.org/2063623002/diff/1/remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc#newcode23 remoting/tools/javascript_key_tester/pnacl/remoting_key_tester.cc:23: LogToConsole(PP_LOGLEVEL_LOG, On 2016/06/13 17:25:42, Jamie wrote: > I don't ...
4 years, 6 months ago (2016-06-13 20:23:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063623002/20001
4 years, 6 months ago (2016-06-13 20:24:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 20:30:49 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 20:31:03 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:33:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55492620e9b09c593cd353b2a9f77317a4837d7f
Cr-Commit-Position: refs/heads/master@{#399525}

Powered by Google App Engine
This is Rietveld 408576698