Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2063583002:
Disable DCHECKs on linux_chromium_msan_rel_ng. (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable DCHECKs on linux_chromium_msan_rel_ng.
It seems likely that DCHECKs are producing sanitizer failures
that aren't showing up on the continuous builder.
R=thakis@chromium.org
BUG=619349
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng
Committed: https://crrev.com/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1
Cr-Commit-Position: refs/heads/master@{#399492}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
dpranke@chromium.org changed reviewers: + eugenis@chromium.org
Please take a look. Ignore the chromeos_ failures; I was triggering the wrong bot by mistake. It does look like DCHECKs are the culprit, and since we don't have debug MSAN bots, this isn't all that surprising.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063583002/1
thakis@chromium.org changed reviewers: + hans@chromium.org
lgtm I'm cautiously very excited about having a working msan trybot for clang rolls!
Description was changed from ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 ========== to ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ==========
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063583002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063583002/1
Message was sent while issue was closed.
Description was changed from ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ========== to ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng ========== to ========== Disable DCHECKs on linux_chromium_msan_rel_ng. It seems likely that DCHECKs are producing sanitizer failures that aren't showing up on the continuous builder. R=thakis@chromium.org BUG=619349 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_msan_rel_ng Committed: https://crrev.com/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 Cr-Commit-Position: refs/heads/master@{#399492} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/21c7ec62eb16ba8144bc9913994d0b437c4ddfa1 Cr-Commit-Position: refs/heads/master@{#399492} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
