third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2063543002: LayoutObject::paintInvalidationParent() to fix multicol spanner invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2063543002: LayoutObject::paintInvalidationParent() to fix multicol spanner invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: LayoutObject::paintInvalidationParent() to fix multicol spanner invalidation Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/repaint/multicol-spanner-background-color-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index 41ca9c6c3a2321d73710d7baa0dae848ded8de17..f417cda7e924dfa9a6c8d8b82ffda4a83e200ad5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1667,7 +1667,11 @@ private:

// The passed rect is mutated into the coordinate space of the paint invalidation container.

const LayoutBoxModelObject* invalidatePaintRectangleInternal(const LayoutRect&) const;

- LayoutObject* parentCrossingFrameBoundaries() const;

+ // Returns the parent for paint invalidation.

+ // - For LayoutView, returns the owner layout object in the containing frame if any or nullptr;

+ // - For multi-column spanner, returns the spanner placeholder;

+ // - Otherwise returns parent().

+ LayoutObject* paintInvalidationParent() const;

static LayoutPoint uninitializedPaintOffset() { return LayoutPoint(LayoutUnit::max(), LayoutUnit::max()); }