Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/offline_pages/background/request_queue.h

Issue 2063533002: Rewrite enum in MACRO_STYLE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.h
diff --git a/components/offline_pages/background/request_queue.h b/components/offline_pages/background/request_queue.h
index 5df83fd13d637a7d09f6b56df9f4cc86a11a4034..d46b9f108603933972203ba8373a69c04c754bc2 100644
--- a/components/offline_pages/background/request_queue.h
+++ b/components/offline_pages/background/request_queue.h
@@ -22,21 +22,21 @@ class SavePageRequest;
class RequestQueue {
public:
enum class GetRequestsResult {
- kSuccess,
- kStoreFailure,
+ SUCCESS,
+ STORE_FAILURE,
};
enum class AddRequestResult {
- kSuccess,
- kStoreFailure,
- kRequestQuotaHit, // Cannot add a request with this namespace, as it has
- // reached a quota of active requests.
+ SUCCESS,
+ STORE_FAILURE,
+ REQUEST_QUOTA_HIT, // Cannot add a request with this namespace, as it has
+ // reached a quota of active requests.
};
enum class UpdateRequestResult {
- kSuccess,
- kStoreFailure,
- kRequestDoesNotExist, // Failed to delete the request because it does not
+ SUCCESS,
+ STORE_FAILURE,
+ REQUEST_DOES_NOT_EXIST, // Failed to delete the request because it does not
// exist.
fgorski 2016/06/11 16:25:06 nit: align the line to the comment above.
Vivian 2016/06/13 17:07:04 Done.
};

Powered by Google App Engine
This is Rietveld 408576698