Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 206353002: Fix for performance issue 353661 - 23% regression in dromaeo. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Fix for performance issue 353661 - 23% regression in dromaeo. The issue was that a previous fix to avoid a logic error was not targeted enough: it allowed non-transitioning stores to fall into a code path meant to preserve monomorphic state in the case of a transitioning store. BUG=353661 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Toon, PTAL, thx! --Michael
6 years, 9 months ago (2014-03-20 11:01:25 UTC) #1
Toon Verwaest
Doh! :) LGTM
6 years, 9 months ago (2014-03-20 13:04:52 UTC) #2
mvstanton
Committed patchset #1 manually as r20127 (presubmit successful).
6 years, 9 months ago (2014-03-20 13:38:14 UTC) #3
Weiliang
6 years, 8 months ago (2014-04-02 08:20:11 UTC) #4
Message was sent while issue was closed.
On 2014/03/20 13:38:14, mvstanton wrote:
> Committed patchset #1 manually as r20127 (presubmit successful).

Hi Micheal,
Will V8 back port this patch to 3.24 branch. This CL seems to have big
performance impact on DOM cases. I see that your previous
patch(https://code.google.com/p/v8/source/detail?r=19893) is already in V8
3.24.35.17.It would be better we also back port this patch to fix the
performance issue in V8 3.24 (Chrome M34).

Thanks
-Weiliang

Powered by Google App Engine
This is Rietveld 408576698