third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 2063473002: Make 2D canvas disable gpu acceleration when getImageData is called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 2063473002: Make 2D canvas disable gpu acceleration when getImageData is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments and fix test failures Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLCanvasElement.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index fd63a8c4c28799f5b87de40cc57d89f3b1e1f93c..5b5d29e843231598da863f36a4d5c0a8304b907c 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -318,6 +318,13 @@ void HTMLCanvasElement::didFinalizeFrame()

m_dirtyRect = FloatRect();

}

+void HTMLCanvasElement::didDisableAcceleration()

+ // We must force a paint invalidation on the canvas even if it's

+ // content did not change because it layer was destroyed.

+ didDraw(FloatRect(0, 0, size().width(), size().height()));

void HTMLCanvasElement::restoreCanvasMatrixClipStack(SkCanvas* canvas) const

{

if (m_context)