xfa/fxbarcode/qrcode/BC_QRDetector.cpp - Issue 2063463002: Trust the compiler to do array indexing and superclass promotion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/qrcode/BC_QRDetector.cpp

Issue 2063463002: Trust the compiler to do array indexing and superclass promotion. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: merge blocks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fxbarcode/qrcode/BC_QRDetector.cpp

diff --git a/xfa/fxbarcode/qrcode/BC_QRDetector.cpp b/xfa/fxbarcode/qrcode/BC_QRDetector.cpp

index 3ed1ea14b89d2abaa486e4ed0caf4830ec2a1b77..a5be32a232d5187645841f2aa374c806d403c8e9 100644

--- a/xfa/fxbarcode/qrcode/BC_QRDetector.cpp

+++ b/xfa/fxbarcode/qrcode/BC_QRDetector.cpp

@@ -91,7 +91,7 @@ CBC_QRDetectorResult* CBC_QRDetector::ProcessFinderPatternInfo(

}

CBC_CommonBitMatrix* bits =

SampleGrid(m_image, topLeft.get(), topRight.get(), bottomLeft.get(),

- (CBC_ResultPoint*)(alignmentPattern), dimension, e);

+ alignmentPattern, dimension, e);

BC_EXCEPTION_CHECK_ReturnValue(e, nullptr);

CFX_ArrayTemplate<CBC_ResultPoint*>* points =

« no previous file with comments | « xfa/fgas/layout/fgas_textbreak.cpp ('k') | no next file » | no next file with comments »