Trust the compiler to do array indexing and superclass promotion.

Trust the compiler to do array indexing and superclass promotion.

Committed: https://pdfium.googlesource.com/pdfium/+/f49747f5fc85ea2acf0c5ff0ab589ad791bf6648

[Tom Sepez, 2016-06-10 21:35:14]

Description was changed from

==========
Trust the compiler to to array indexing and superclass promotion.
==========

to

==========
Trust the compiler to do array indexing and superclass promotion.
==========

[Tom Sepez, 2016-06-10 21:35:15]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-06-10 21:35:35]

Lei, don't know what to say about this one.

[Lei Zhang, 2016-06-10 21:40:47]

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
xfa/fgas/layout/fgas_rtfbreak.cpp:995: } else if (nCur == FX_CBP_TB) {
This block looks identical to the one above. Merge?

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
xfa/fgas/layout/fgas_rtfbreak.cpp:1004: } else if (bInfixBreak && nCur ==
FX_CBP_IS && nNext == FX_CBP_IS) {
Merge with the one above.

[Tom Sepez, 2016-06-10 21:56:57]

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
File xfa/fgas/layout/fgas_rtfbreak.cpp (right):

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
xfa/fgas/layout/fgas_rtfbreak.cpp:995: } else if (nCur == FX_CBP_TB) {
On 2016/06/10 21:40:47, Lei Zhang wrote:
> This block looks identical to the one above. Merge?

Not quite.  One sets bNeedBreak to !bSpaceBreak and the other sets it to
!bTabBreak.

https://codereview.chromium.org/2063463002/diff/1/xfa/fgas/layout/fgas_rtfbre...
xfa/fgas/layout/fgas_rtfbreak.cpp:1004: } else if (bInfixBreak && nCur ==
FX_CBP_IS && nNext == FX_CBP_IS) {
On 2016/06/10 21:40:47, Lei Zhang wrote:
> Merge with the one above.

Done.

[Lei Zhang, 2016-06-10 22:00:40]

lgtm

[Tom Sepez, 2016-06-10 22:07:58]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-06-10 22:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063463002/20001

[commit-bot: I haz the power, 2016-06-10 22:24:55]

Description was changed from

==========
Trust the compiler to do array indexing and superclass promotion.
==========

to

==========
Trust the compiler to do array indexing and superclass promotion.

Committed:
https://pdfium.googlesource.com/pdfium/+/f49747f5fc85ea2acf0c5ff0ab589ad791bf...
==========

[commit-bot: I haz the power, 2016-06-10 22:24:56]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/f49747f5fc85ea2acf0c5ff0ab589ad791bf...