Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 2063453003: [MD settings] not clipping ink ripple in spelling settings (Closed)

Created:
4 years, 6 months ago by dschuyler
Modified:
4 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] not clipping ink ripple in spelling settings This CL reduces the use of overflow: hidden to places that need it, than having it set on .start and .middle which are more about position than elision. BUG=608647 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/79d84b4f8c318dda15dc5708ecd871f7aafd35d2 Cr-Commit-Position: refs/heads/master@{#399555}

Patch Set 1 : cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 2 chunks +5 lines, -1 line 2 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dschuyler
This fixes one form of ink ripple clipping. There are two other sources of clipping ...
4 years, 6 months ago (2016-06-11 01:39:09 UTC) #4
michaelpg
https://codereview.chromium.org/2063453003/diff/20001/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html File chrome/browser/resources/settings/on_startup_page/startup_url_entry.html (right): https://codereview.chromium.org/2063453003/diff/20001/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html#newcode30 chrome/browser/resources/settings/on_startup_page/startup_url_entry.html:30: <div class="middle hide-overflow"> [Why] is this the only place ...
4 years, 6 months ago (2016-06-13 16:01:57 UTC) #5
dschuyler
https://codereview.chromium.org/2063453003/diff/20001/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html File chrome/browser/resources/settings/on_startup_page/startup_url_entry.html (right): https://codereview.chromium.org/2063453003/diff/20001/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html#newcode30 chrome/browser/resources/settings/on_startup_page/startup_url_entry.html:30: <div class="middle hide-overflow"> On 2016/06/13 16:01:57, michaelpg wrote: > ...
4 years, 6 months ago (2016-06-13 19:25:19 UTC) #6
michaelpg
lgtm
4 years, 6 months ago (2016-06-13 19:40:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063453003/20001
4 years, 6 months ago (2016-06-13 20:58:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-13 21:48:33 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:48:53 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:50:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79d84b4f8c318dda15dc5708ecd871f7aafd35d2
Cr-Commit-Position: refs/heads/master@{#399555}

Powered by Google App Engine
This is Rietveld 408576698