Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2063413002: BridgedContentView: Modify IsTextRTL to use TextInputClient::GetTextDirection. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BridgedContentView: Modify IsTextRTL to use TextInputClient::GetTextDirection. crrev.com/2024003002 introduced GetTextDirection to the TextInputClient API. This CL modifies IsTextRTL in BridgedContentView to use the newly added TextInputClient::GetTextDirection method, instead of recomputing the directionality of text every time. BUG=618184 Committed: https://crrev.com/d3d07f1e6205d7355e0b072c384dcd1a318c2c71 Cr-Commit-Position: refs/heads/master@{#399853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M ui/views/cocoa/bridged_content_view.mm View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
karandeepb
PTAL Trent.
4 years, 6 months ago (2016-06-15 05:15:54 UTC) #3
tapted
lgtm
4 years, 6 months ago (2016-06-15 05:45:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063413002/1
4 years, 6 months ago (2016-06-15 06:05:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 06:48:01 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 06:48:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 06:49:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3d07f1e6205d7355e0b072c384dcd1a318c2c71
Cr-Commit-Position: refs/heads/master@{#399853}

Powered by Google App Engine
This is Rietveld 408576698