Issue 2063373003: [turbofan] Mark side-effect-free calls to string ops as kEliminatable.

Issue 2063373003: [turbofan] Mark side-effect-free calls to string ops as kEliminatable. (Closed)

Created:
4 years, 6 months ago by Jarin

Modified:
4 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Mark side-effect-free calls to string ops as kEliminatable. Committed: https://crrev.com/14a1a7edf46dfa728ffd1678793a15009e461a60 Cr-Commit-Position: refs/heads/master@{#36996}

Created: 4 years, 6 months ago

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -14 lines)
M	src/compiler/effect-control-linearizer.cc	View	1 chunk	+1 line, -0 lines	0 comments
M	src/compiler/simplified-lowering.cc	View	8 chunks	+4 lines, -8 lines	0 comments
A +	test/mjsunit/compiler/regress-string-to-number-add.js	View	1 chunk	+8 lines, -6 lines	0 comments

Total messages: 11 (4 generated)

Jarin

Could you take a look, please? (This is a quick fix, we should move the ...

4 years, 6 months ago (2016-06-15 11:00:40 UTC) #3

Jarin

Could you take a look, please? (This is a quick fix, we should move the ...

4 years, 6 months ago (2016-06-15 11:00:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063373003/1

4 years, 6 months ago (2016-06-15 11:05:34 UTC) #7

commit-bot: I haz the power

4 years, 6 months ago (2016-06-15 11:39:49 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/14a1a7edf46dfa728ffd1678793a15009e461a60
Cr-Commit-Position: refs/heads/master@{#36996}